Een hart voor de Drupal Community

Sven Decabooter added a comment on drupal.org: First draft of module

Sven Decabooter added a comment on drupal.org: [roleassign] RoleAssign

Sven Decabooter added a comment on drupal.org: Modal Does not Close Automatically (possibly only on multilingual sites)

Sven Decabooter added a comment on drupal.org: Automated Drupal 11 compatibility fixes for route_condition

Sven Decabooter added a comment on drupal.org: Automated Drupal 11 compatibility fixes for teamleader

Sven Decabooter added a comment on drupal.org: Support OOP hooks

Sven Decabooter added a comment on drupal.org: Deprecate module for ai 1.2.x

No longer needed - see #3536212: Deprecate module for ai 1.2.x

No longer needed - see #3536212: Deprecate module for ai 1.2.x

Rebasing / fixing of merge conflict causes a new issue in test Drupal\Tests\openid_connect\Functional\Update\IssAllowedSchemaUpdate30004Test::testUpdateHook30003

Not sure how this is related, except that earlier hook also updated plugin config. Maybe it now fails because in our update hook we also update the plugin config further. Any insights from maintainers as to how to solve this would be appreciated.

Updated the MR to fix a merge conflict with hook_update_x numbering.

Sven Decabooter added a comment on drupal.org: Implement OOP preprocess hook

svendecabooter created an issue. See original summary.

Problem/Motivation

Add support for Preprocess OOP hooks. See https://www.drupal.org/node/3496491 Add backwards compatibility.

Does this issue still exist on the latest version of the module?

Sven Decabooter added a comment on drupal.org: layout_builder_iframe_modal_link_alter no longer works when contextual is enabled.

Sven Decabooter added a comment on drupal.org: The website encountered an unexpected error. Try again later. TypeError: implode(): Argument #1 ($array) must be of type array, string given in implode() (line 74 of modules/contrib/layout_builder_iframe_modal/src/Form/LayoutBuilderIframeModalSettingsFor

That seems more like an issue of a bad workflow regarding config management... But the proposed fix is fairly straight forward, so will add it as an extra safeguard.

Sven Decabooter added a comment on drupal.org: The website encountered an unexpected error. Try again later. TypeError: implode(): Argument #1 ($array) must be of type array, string given in implode() (line 74 of modules/contrib/layout_builder_iframe_modal/src/Form/LayoutBuilderIframeModalSettingsFor

Sven Decabooter added a comment on drupal.org: Make compatible with 'Administer users by role' module

Improved the logic from #3451443: Add permission for resending emails to make it compatible with other modules, that provide a workaround for the broad 'administer users' permission. Now you can access the feature when you have 'administer users' permission, or the module-specific permission.

svendecabooter made their first commit to this issue’s fork.

Added the new permission, while keeping the existing access logic intact. You can now use this functionality if you are able to update user entities (current access logic), OR apply the action to user entities if you have the newly added permission granted.

I guess you would need to debug this via XDebug or something... Alternatively, you could switch to using the Drupal Symfony Mailer Plus module with an SMTP transport configured, and install Drupal Symfony Mailer Log module. This will create a log entry for each outgoing email, making it easier to debug if the mail is going out or not.

Sorry for not coming back to this. That seems like a useful feature to be added to an optional submodule, for users seeking that functionality. Or within the module itself as a configuration option (but disabled by default).

Sven Decabooter added a comment on drupal.org: Dependencies module missinge in info.yml

Looks good, thanks!

Sven Decabooter added a comment on drupal.org: Use PHP attributes instead of annotations

Weird, I can't seem to reproduce this (although I'm testing with Drupal 11.2 currently). Version 1.3.6 didn't introduce anything that should break this again, so it's probably due to core changes.

@nidhi27 yeah that was my rough idea... not sure if that's easily doable.