Een hart voor de Drupal Community

Fons added a comment on drupal.org: Is it possible to add a marker popup with text when using the form formatter (Leaflet Map Default)

Problem/Motivation

Hello, i'm currently using this awesome module and it's really nice. Thank you!

The only feature that I miss / can't find is how to add marker popup data (preferably text) when using the form formatter (Leaflet Map Default).

Now I can add markers (without data / pop-up info), polygons, lines, etc.

How can this be achieved, can anyone put me in the right direction?

Thanks in advance!

f0ns created an issue. See original summary.

I got rid of the patch and added the preprocess block as suggested in comment #92 and #94.

This works with bigpipe.

Thank you, this is the cleanest solution for now (for me) as I don't have to patch core.

The patch #28 works for me. I would like to thank you for this work!

A small nitpick, please use - instead of . in patch filenames in the future.

[module-name]-[short-description]-[issue-number]-[comment-number].patch
# e.g. some_module-some-bug-123456-3.patch

I can confirm the MR applies to 1.25.

I now get the aria-label="Cookie privacy banner" parameter in the popup's HTML tag.

(PS. Let's keep working in the MR -if anything needs to change- rather than attaching patches)

ivnish,

I updated your role in Git!

Hi ivnish,

I just added you as a co-maintainer. All help on the project is welcome!

Kind regards Brecht Ceyssens

Please, feel free to review.

This fixes the issue of terms always being rendered in their default language, rather than the current language.

Problem/Motivation

As a result of #2615864, this module also suffers from issues with translations. It always retrieves taxonomy terms in their default language, rather than the current language.

Steps to reproduce

Create translations of the dictionary vocabulary terms, and add the words to a page in a different language than the default language of the terms.

Proposed resolution

Slightly rework the functionality regarding the loading of taxonomy terms in the TooltipManager class.

I will create a MR with my proposal.

randalv created an issue. See original summary.

Hi Hauke,

Did you find the ResponsiveImageFormatter? https://git.drupalcode.org/project/combined_image_style/-/blob/1.0.x/src... I also created a formatter for media fields in a project of ours so you can configure combinations for each breakpoint in the display of an entity. No need for responsive images styles. Is that what you're looking for? If so, I can add my work to the project.

I just tested the patch in comment #4 and everything seems to work fine.

I was wondering if this can get merged in a new release?

For now I'll use the patch as this is one of the modules that holds me from upgrading to Drupal 11.

Thank you!

Fons added a comment on drupal.org: Install Tocbot library with composer

Here is a patch that updates the README.

TODO: Update the project page with these instructions.

Fons added a comment on drupal.org: Install Tocbot library with composer

Fons added a comment on drupal.org: Install Tocbot library with composer

Problem/Motivation

It would be nice if we could add the steps to add the Tocbot library that is used by this module with composer.

Proposed resolution

Update the Readme file and project detail page on drupal.org

Remaining tasks

Create a patch, if you are open to this suggestion I don't mind creating and posting the patch. -> Patch in comments

As I see it now the following steps are needed:

INSTALLATION VIA COMPOSER

1. It is assumed you are installing Drupal with Composer (https://www.drupal.org/download).

2. Add the following entry in the "repositories" section of your main composer.json file.

{
            "type": "package",
            "package": {
                "name": "tscanlin/tocbot",
                "version": "4.30.0",
                "type": "drupal-library",
                "source": {
                    "url": "https://github.com/tscanlin/tocbot",
                    "type": "git",
                    "reference": "v4.30.0"
                }
            }
        }

Now you can run the following command to install chosen in the right folder:

composer require tscanlin/tocbot

3. Clear the cache 4. Go to Administration > Configuration > Content Authoring > Tocbot Settings (/admin/config/content/tocbot) 5. Configure the module to your needs 6. Click "Save configuration"

f0ns created an issue. See original summary.

Dear gausarts, thank you for the compliment and sorry to read that.

Just a thought:

If we would toggle this setting by default in the install file of the module it would only trigger / set it default for new installs.

Existing installs wouldn't be affected, if you want to affect those (which you don't and I totally get that) you would add this in an update hook.

If you are interested in a patch for the install file i'd be happy to make it but it is not a dealbreaker for me.

Thank you for all your work and have a great evening! There are a lot of good people out there so try to focus on those, that may help!

Thank you for your reply, I checked the Blazy settings page but it seems that I read over the checkbox to disable these classes.

I just checked the setting and everything looks better / clean now.

If I may suggest an upgrade I think it's fair to check this setting by default as a clean DOM is preffered over all these classes in most cases but that is just my view.

Thanks!

Fons added a comment on drupal.org: Blazy renders the same classes on all blazy elements on a page.

I created a patch that cleans out the function so the DOM is now a lot less bloated with unneeded classes.

I might miss the point why all these classes are added on every media element but they are not needed for the module to work and I don't see the value they add.

Feel free to enlighten me.

Problem/Motivation

I'm using blazy on a page in different layout blocks.

I've noticed the blazy field gets injected with the same classes for all media fields which to me makes no sense.

Steps to reproduce

Create a page with multiple blazy elements, you'll notice the same group of classes is used on all elements instead of the relevant classes per item.

Proposed resolution

Don't make a huge group of classes and render them on all elements but instead only show the relevant classes per item.

The classes are added in an array in the following file:

blazy/src/Attributes.php

in the following function:

/**
   * Returns the classes applicable only to the first, not nested containers.
   */
  private static function firstClasses(array &$attributes, $blazies, array $options): array {

If you print the classes before the return you'll see the same array that is printed for every item.

Remaining tasks

Needs review

f0ns created an issue. See original summary.

Thank you for testing, looks good to go.

Concerning comment #6, personally I don’t see the need to add extra control statements to other regions as these elements have no containers that have any css markup in core.

Thank you, the patch provided works great here!

The notice in https://pagespeed.web.dev is gone now and the accessibility score increased.

Thanks!

The comment in #110 works perfectly (I only use the GA portion).

Thanks!

Thanks for the patch/MR. I've applied the MR diff to one of our sites, and the issue has been resolved.

Hopefully this finds its way into a release 🙏

Brecht Ceyssens added a comment on drupal.org: Add support for hiding webform submissions settings